Phase out curve25519 for x25519 and ed25519 #4545
Draft
+1,309
−1,164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
reviewed
Apr 18, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
This PR needs nymtech/sphinx#94 to be merged in so dependency to sphinx can be updated and properly pull the version from crates.io |
|
Sphinx's crate new version was released, so this PR is now ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
curve25519-dalekbyed25519-dalekandx25519-dalek.Also upgrade those crate,
ed25519to 2.1 andrandto 0.8WARNING : This PR will break compatibility. Updated used sphinx library uses x25519 scalar clamping vs scalar reduction that is currently done
This change is